Support multi-named keywords without underscore#213
Merged
ulmer-a merged 5 commits intoPLC-lang:masterfrom Jul 30, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #213 +/- ## ========================================== + Coverage 96.70% 96.76% +0.05% ========================================== Files 41 41 Lines 15392 15430 +38 ========================================== + Hits 14885 14931 +46 + Misses 507 499 -8
Continue to review full report at Codecov.
|
Collaborator Author
|
|
7a1d4fe to 9d6c579 Compare This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
Support multi-named keywords and log a diagnostic when encountered. The user should be encouraged to use the underscore variants by an error message similar to "found ENDFUNCTIONBLOCK, consider using END_FUNCTION_BLOCK instead".