Conversation
riederm requested changes Nov 3, 2021
Collaborator
riederm left a comment
riederm left a comment There was a problem hiding this comment.
overall looks good,
can add the same treatment for DATE_AND_TIME?
Codecov Report
@@ Coverage Diff @@ ## master #360 +/- ## ======================================= Coverage 95.76% 95.77% ======================================= Files 51 51 Lines 14606 14611 +5 ======================================= + Hits 13988 13993 +5 Misses 618 618
Continue to review full report at Codecov.
|
…f_it_has_3_sections
riederm approved these changes Nov 4, 2021
99NIMI deleted the issue-355-TOD-Literal_can_only_be_parsed_if_it_has_3_sections branch This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.