Add validation-only flag (--check)#510
Merged
ghaith merged 2 commits intoPLC-lang:masterfrom Jul 4, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #510 +/- ## ========================================== - Coverage 93.00% 92.99% -0.01% ========================================== Files 40 40 Lines 14468 14523 +55 ========================================== + Hits 13456 13506 +50 - Misses 1012 1017 +5
Continue to review full report at Codecov.
|
Collaborator
| Hi Alex, so nice hearing from you! thx for the PR - i'll check it these days. |
ghaith approved these changes Jul 4, 2022
Collaborator
ghaith left a comment
ghaith left a comment There was a problem hiding this comment.
Hello Alex! Nice to hear from you again :)
Thank you for your contribution, this looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi guys, hope you're doing well! I had some spare time, so I thought I'd catch up with the project and drop you a PR. Things are moving quickly...!
This should fix #482.
I split up
compile_module()intoindex_module()andcompile_module()so that the two can be called independently (the check option then only calls index_module and doesn't generate code).Hope it helps!