Merged
Conversation
ghaith requested changes Jul 25, 2022
Collaborator
ghaith left a comment
ghaith left a comment There was a problem hiding this comment.
Some things we need to change, but in general looks good 👍
Codecov Report
@@ Coverage Diff @@ ## master #523 +/- ## ========================================== - Coverage 93.16% 92.30% -0.87% ========================================== Files 41 42 +1 Lines 14857 15024 +167 ========================================== + Hits 13842 13868 +26 - Misses 1015 1156 +141
Continue to review full report at Codecov.
|
ghaith reviewed Jul 26, 2022
Collaborator
ghaith left a comment
ghaith left a comment There was a problem hiding this comment.
Just some small comments, we can discuss them / solve them tomorrow in pair
ghaith reviewed Jul 28, 2022
ghaith reviewed Jul 28, 2022
ghaith reviewed Jul 28, 2022
ghaith approved these changes Jul 28, 2022
Collaborator
| I'm approving this for now, you can change the typos in the packaging or the followup commit |
flavioBachmann added a commit to flavioBachmann/rusty that referenced this pull request Jul 28, 2022
ghaith added a commit that referenced this pull request Aug 2, 2022
* validate Pointer incl. tests * using cargo clippy for coding style as well as cargo fmt * multi-type declarations incl. tests * subcommand as well as simple build description file * improved subcommand * improved build description file * adding libraries and parsing them * documentation and minor improvements * Pull Request improvements * package_commands for build description file * changes after review * improvements from review * adding sysroot and target-triple as inline parameters for subcommand * addingchangable build location * typos from Build Description File #523 * tests added * Small review changes * change relative path to absolut, improved tests * adapt test for windows * tests improved * Made the build work regadless of start location * make every key optional/default * typo * Added lib location to build parameters, made sure default names are calculated from input Co-authored-by: Ghaith Hachem <ghaith.hachem@bachmann.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started to implement the build description file mentioned in issue #483