Skip to content

use zmij#448

Open
chirizxc wants to merge 1 commit intoParkMyCar:mainfrom
chirizxc:zmij
Open

use zmij#448
chirizxc wants to merge 1 commit intoParkMyCar:mainfrom
chirizxc:zmij

Conversation

Copy link
Contributor

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a maintainer, but maybe better as a feature, since ryu is pure rust code and easier to compile?

@chirizxc
Copy link
Contributor Author

Not a maintainer, but maybe better as a feature, since ryu is pure rust code and easier to compile?

this pure rust implementation https://github.com/dtolnay/zmij

@chirizxc
Copy link
Contributor Author

by the same author as ryu, but initially I posted a link to the original repository for a faster algorithm

@NobodyXu
Copy link
Contributor

Thanks, the link in ur description is wrong, it seems to take me to the c implementation instead

@ParkMyCar
Copy link
Owner

Thanks @chirizxc for the PR! Even though the library is authored by dtolnay I don't want to switch over to it 100% since it's only a few days old.

+1 to what @NobodyXu mentioned about feature gating this. Could you make zmij an optional dependency and only use it when the feature is enabled?

@chirizxc
Copy link
Contributor Author

Thanks @chirizxc for the PR! Even though the library is authored by dtolnay I don't want to switch over to it 100% since it's only a few days old.

+1 to what @NobodyXu mentioned about feature gating this. Could you make zmij an optional dependency and only use it when the feature is enabled?

Essentially, it's just a faster algorithm. For example, in serde-rs/json / miniserde, ryu has already been replaced with zmij.

serde-rs/json#1304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants