Setting socket options may fail if remote has already disappeared#399
Merged
digitalresistor merged 1 commit intomainfrom Jan 23, 2023
Merged
Conversation
By the time we come around to accepting a connection on macOS, the remote may have already disappeared, in which case setting options on the socket may fail with an error. Instead of failing and shutting down the server we want to continue, so move the setting of socket options into the try/except block and log the error instead.
digitalresistor deleted the bugfix/move-socket-options-setting-into-try-except branch netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jun 13, 2024
3.0.0 (2024-02-04) ------------------ - Rename "master" git branch to "main" - Fix a bug that would appear on macOS whereby if we accept() a socket that is already gone, setting socket options would fail and take down the server. See Pylons/waitress#399 - Fixed testing of vendored asyncore code to not rely on particular naming for errno's. See Pylons/waitress#397 - HTTP Request methods and versions are now validated to meet the HTTP standards thereby dropping invalid requests on the floor. See Pylons/waitress#423 - No longer close the connection when sending a HEAD request response. See Pylons/waitress#428 - Always attempt to send the Connection: close response header when we are going to close the connection to let the remote know in more instances. Pylons/waitress#429 - Python 3.7 is no longer supported. Add support for Python 3.11, 3.12 and PyPy 3.9, 3.10. See Pylons/waitress#412 - Document that trusted_proxy may be set to a wildcard value to trust all proxies. See Pylons/waitress#431
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time we come around to accepting a connection on macOS, the remote may have already disappeared, in which case setting options on the socket may fail with an error.
Instead of failing and shutting down the server we want to continue, so move the setting of socket options into the try/except block and log the error instead.
Closes #383