Skip to content

Fix PageController.page cannot be accessed before a PageView is built with it.#178

Merged
ghenry merged 5 commits intoPyozer:masterfrom
damphat:master
May 30, 2023
Merged

Fix PageController.page cannot be accessed before a PageView is built with it.#178
ghenry merged 5 commits intoPyozer:masterfrom
damphat:master

Conversation

@damphat
Copy link
Contributor

@damphat damphat commented May 4, 2023

The last fix used CancelableOperation.fromFuture, which cannot break the async code. Let's use mounted property instead.
@Macacoazul01 Macacoazul01 mentioned this pull request May 6, 2023
Merged
@ghenry
Copy link
Collaborator

ghenry commented May 30, 2023

Can we clean up failing tests? Thanks.
@damphat
Copy link
Contributor Author

damphat commented May 30, 2023

Done, I have run dart fix --apply to fix the problems with the latest flutter
@ghenry ghenry changed the title Fixed #175 Fix PageController.page cannot be accessed before a PageView is built with it. May 30, 2023
@damphat
Copy link
Contributor Author

damphat commented May 30, 2023 •
edited
Loading

Done
The problem is that the Podfile generated by flutter 3.10.2 not work with the current example app.
The easiest way to fix this is regenerate the example with the command line flutter create --platforms ...
@ghenry ghenry merged commit 84693ad into Pyozer:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@damphat @ghenry