some changes and fixes to auto scroll#186
Merged
ghenry merged 6 commits intoPyozer:masterfrom Jun 8, 2023
Macacoazul01:master
Merged
some changes and fixes to auto scroll#186ghenry merged 6 commits intoPyozer:masterfrom Macacoazul01:master
ghenry merged 6 commits intoPyozer:masterfrom
Macacoazul01:master
Conversation
This was referenced Jun 8, 2023
ghenry reviewed Jun 8, 2023
Collaborator
ghenry left a comment
ghenry left a comment There was a problem hiding this comment.
Is this a breaking change removing those options?
Contributor Author
| Unfortunately it is kind of... The behavior of the package will remain as the safe list replace these options, but as they will be removed, it can break some users code. |
Contributor Author
| As there is already the dots to int breaking that wasn't added officially to a version, I took the opportunity to do this one too |
Collaborator
| Didn't we revert that and want to do a breaking change major version? Can't recall. |
Contributor Author
| Nope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.