feat(vscode-ide-companion): support /insight command#2593
feat(vscode-ide-companion): support /insight command#2593yiliang114 wants to merge 9 commits intomainfrom
Conversation
Add ACP support for /insight progress streaming and report opening in the VSCode companion. Resolves #2023
📋 Review SummaryThis PR adds 🔍 General Feedback
🎯 Specific Feedback🟡 High
🟢 Medium
🔵 Low
✅ Highlights
|
This reverts commit 3209274.
This reverts commit 3b08491.
This reverts commit 386c5c6.
This reverts commit e271614.
- Replace `formatAcpInsightProgress` with `encodeAcpInsightProgress` using JSON payload - Move imports to top-level, no longer defer loading for non-ACP mode - Remove `INSIGHT_READY_MARKER` parsing from Session.ts as it's now handled by WebViewProvider
Move INSIGHT_PROGRESS_MARKER and INSIGHT_READY_MARKER from cli and vscode-ide-companion packages to @qwen-code/qwen-code-core for better shareability and to avoid duplication. Also extract ACP_ALLOWED_COMMANDS constant in Session.ts to improve readability and maintainability.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
TLDR
Support
/insightin VSCode Companion so users can generate insight reports without switching back to the terminal.This adds ACP-side progress streaming and a VSCode-side report-open handoff when generation completes.
Screenshots / Video Demo
N/A — no user-facing screenshot included in this draft.
Dive Deeper
/insightin the ACP slash-command path used by VSCode Companion./insightprogress updates over ACP and emit a dedicated report-ready notification with the generated HTML path.Open Reportaction viavscode.env.openExternal.Reviewer Test Plan
/insight.Open Reportaction.Open Reportand confirm the generated local HTML report opens successfully.Testing Matrix
Executed:
npx vitest run packages/cli/src/ui/commands/insightCommand.test.ts packages/cli/src/acp-integration/session/Session.test.ts packages/vscode-ide-companion/src/services/acpConnection.test.ts packages/vscode-ide-companion/src/webview/providers/WebViewProvider.test.tsnpm run --workspace=packages/vscode-ide-companion check-typesLinked issues / bugs
Resolves #2023
Related to #1991
Related to #1985
Related to #1990