Fix argument mismatches for implicitly defined functions (gcc-10 compat) #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| ok, thank you! Pushing this one and going to close #23 then. |
This was referenced Jun 26, 2020
Closed
5 tasks
Closed
This was referenced Jun 12, 2025
pradeeptrgit pushed a commit to amd/aocl-scalapack that referenced this pull request Nov 24, 2025
Fix argument mismatches for implicitly defined functions (gcc-10 compat)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While the original pattern starts to break with GCC 10+, it wasn't portable for a long time already.
Instead of setting
-fallow-argument-mismatchfor the whole project as in #23 I only set-std=legacyfor the tests while the files inSRC/are properly fixed.(sorry for the spam, used the wrong branch from my repo)