Skip to content

Fix XhamsterRipper by getting cookies first#1601

Open
ehump12000 wants to merge 4 commits intoRipMeApp:mainfrom
ehump12000:master
Open

Fix XhamsterRipper by getting cookies first#1601
ehump12000 wants to merge 4 commits intoRipMeApp:mainfrom
ehump12000:master

Conversation

@ehump12000
Copy link

@ehump12000 ehump12000 commented Mar 13, 2020

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

The Xhamster ripper will now set its cookies from the first page similar to EightmusesRipper.

Testing

Required verification:

  • I've verified that there are no regressions in mvn test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.
@metaprime metaprime changed the base branch from master to main January 6, 2025 14:13
@metaprime metaprime mentioned this pull request Jan 7, 2025
12 tasks
@metaprime
Copy link
Contributor

Resolved conflicts. Will test and merge later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment