Skip to content

Fix fixed buffer fields#428

Merged
SamboyCoding merged 1 commit intoSamboyCoding:developmentfrom
AssetRipper:fix-fixed-buffer-fields
Mar 22, 2025
Merged

Fix fixed buffer fields#428
SamboyCoding merged 1 commit intoSamboyCoding:developmentfrom
AssetRipper:fix-fixed-buffer-fields

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Mar 21, 2025

Previously, these were unnecessarily initialized in the constructor, causing decompilation issues.

Attributes are used to detect fixed buffer fields, so they have to be applied before filling method bodies.

@coveralls
Copy link

coveralls commented Mar 21, 2025

Pull Request Test Coverage Report for Build 14010526831

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 27.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
Cpp2IL.Core/OutputFormats/AsmResolverDummyDllOutputFormat.cs 2 0.0%
Totals Coverage Status
Change from base Build 14010507177: -0.005%
Covered Lines: 3379
Relevant Lines: 10648

💛 - Coveralls
@SamboyCoding SamboyCoding force-pushed the fix-fixed-buffer-fields branch from ef7512c to c241cd6 Compare March 22, 2025 16:49
@SamboyCoding SamboyCoding merged commit 4409a1b into SamboyCoding:development Mar 22, 2025
5 checks passed
@ds5678 ds5678 deleted the fix-fixed-buffer-fields branch March 22, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants