Workaround a wasm dependency issue Summary: This is a quick and dirty hack that works around a wasm dependency issue. The issue manifests itself in a compile error when including fmt headers during a wasm build. Reviewed By: shodoco Differential Revision: D24516599 fbshipit-source-id: 578dd8981922a97702992a8c30b88b47fef1706e

Explicitly turn off binary resources mode for some tests Reviewed By: jiawei-lyu Differential Revision: D24509926 fbshipit-source-id: 5fd43be96973dfcd1e866001181d3f6fcabfe0ec

Random template fix Summary: The old comma operator version made sense when this was a big ternary. Now it's not necessary. Reviewed By: mhorowitz Differential Revision: D24228765 fbshipit-source-id: 5a25013b367ed4764e1a8d962158b206e1354ecb

Random template fix Summary: The old comma operator version made sense when this was a big ternary. Now it's not necessary. Reviewed By: mhorowitz Differential Revision: D24228765 fbshipit-source-id: 5a25013b367ed4764e1a8d962158b206e1354ecb

Add blackbox trace to ASL FAD reports Summary: Add traces when possible using existing providers. This adds the trace to ACRA/ASL fads only. Lacrima will be a separate diff. Reviewed By: dalves Differential Revision: D23872487 fbshipit-source-id: b2c17021ae8192201db4e3506893cc3d78b33c91

Add blackbox trace to ASL FAD reports Summary: Add traces when possible using existing providers. This adds the trace to ACRA/ASL fads only. Lacrima will be a separate diff. Reviewed By: dalves Differential Revision: D23872487 fbshipit-source-id: b2c17021ae8192201db4e3506893cc3d78b33c91

Allow sample app to start in-memory traces and control providers Summary: This change exposes more of the trace configuration as UI in the sample app. In particular, we can now pick which providers should be part of the active trace, as well as whether the trace should be in-memory only or not. Reviewed By: ricardorey10 Differential Revision: D23847734 fbshipit-source-id: 45b7ba04973f829c43688b3897e4365f7c3545cd

Allow sample app to start in-memory traces and control providers Summary: This change exposes more of the trace configuration as UI in the sample app. In particular, we can now pick which providers should be part of the active trace, as well as whether the trace should be in-memory only or not. Reviewed By: ricardorey10 Differential Revision: D23847734 fbshipit-source-id: 45b7ba04973f829c43688b3897e4365f7c3545cd

Allow sample app to start in-memory traces and control providers Summary: This change exposes more of the trace configuration as UI in the sample app. In particular, we can now pick which providers should be part of the active trace, as well as whether the trace should be in-memory only or not. Reviewed By: ricardorey10 Differential Revision: D23847734 fbshipit-source-id: 45b7ba04973f829c43688b3897e4365f7c3545cd

Avoid temporaries in toCall Summary: The old versions of these functions should look sketchy. A local_ref gets constructed for the pass-by-value argument, then we return the raw jobject right before the local_ref is destroyed. (alias_ref is fine; I just converted it for consistency.) The only reason we get away with this is that this method is always used like `CallMethod(Convert::toCall(something))`. The C++ standard specifies "It is implementation-defined whether the lifetime of a parameter ends when the function in which it is defined returns or at the end of the enclosing full-expression." And the Itanium C++ ABI specifies "If the type has a non-trivial destructor, the caller calls that destructor after control returns to it (including when the caller throws an exception), at the end of enclosing full-expression." So we're safe. The temporary local_ref survives until after CallMethod completes. Except on Windows. MSVC doesn't follow the Itanium ABI. Its ABI requires the callee to invoke the destructor for temporary values constructed for arguments. More discussion at https://quuxplusone.github.io/blog/2018/11/12/parameter-lifetime-and-trivial-abi/ The fix is just to take the arguments by const-reference, so no temporary is constructed. This should be marginally more efficient as well. Reviewed By: cjhopman Differential Revision: D23862672 fbshipit-source-id: b26cfff76d864a3a58934f06d1da8f2b66668a11