This repository was archived by the owner on Apr 5, 2022. It is now read-only.
Rewrite #2
Merged
Rewrite #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This improves the code base a little, it splits all the important parts into seperate headers. I've also reworked how exposing of c++ function works and prevented some crashes. callJSFunction got replaced by callFunction, which now does not have it's own custom implementation by me but instead uses std::future. shouldCloseOnExit got removed but you can now return true inside of the closeCallback to prevent closing of the window. When exposing an AsyncFunction the function will be called in a new thread. The current commit only contains the code for the webkit2gtk implementation, the windows implementation will follow soon and it will fix #1.
chore: add example
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.