Conversation
| Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
| Great work! I guess we should add aberration to the Moon as well (for values < 1, as to keep accuracy for stellar and planetary occultations), otherwise toggling it with high values looks weird with the Moon in frame. |
| I am not sure if DSO icons or even textures need any special treatment, I think they are not in icosaeder zones. Do they also disappear? Concerning the Moon, I just don't understand why aberration should not be applied here. Is it integrated to the usual ephemeris? But what really needs to be done w.r.t. occultations is sketched in #1959 and #1924. |
| Yes, I think the solution to keep occultation timings was to disable it for the Moon as seen from Earth. This suggests the ephemeris has aberration applied to the Moon already. I can't see a difference between DE440/441 and VSOP87, so either all of them have integrated aberration for the Moon (but not planets apparently, which appears to be weird), or the Stellarium code applies it somewhere else. |
Yes they are also disappearing, see below Screen.Recording.2026-02-03.at.7.10.32.PM.mov |
| Some kind of clipping that needs to be extended? |
Description
As @gzotti suggested, adding aberration to geodesic grid corners seems to fix the star disappearance issue. But nebulae/galaxies images/markers still need to be fixed too. I will need more time to find where I should add the aberration to them too or if anyone is more familiar with nebulae/galaxies images/markers, helps would be appreciated!
Fixes #4742
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: