Skip to content

Extend aberration range#4759

Draft
henrysky wants to merge 1 commit intomasterfrom
aberration_range
Draft

Extend aberration range#4759
henrysky wants to merge 1 commit intomasterfrom
aberration_range

Conversation

@henrysky
Copy link
Contributor

@henrysky henrysky commented Feb 3, 2026

Description

As @gzotti suggested, adding aberration to geodesic grid corners seems to fix the star disappearance issue. But nebulae/galaxies images/markers still need to be fixed too. I will need more time to find where I should add the aberration to them too or if anyone is more familiar with nebulae/galaxies images/markers, helps would be appreciated!

Fixes #4742

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this pgzottiroject.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@Atque
Copy link
Contributor

Atque commented Feb 3, 2026

Great work!

I guess we should add aberration to the Moon as well (for values < 1, as to keep accuracy for stellar and planetary occultations), otherwise toggling it with high values looks weird with the Moon in frame.

@gzotti
Copy link
Member

gzotti commented Feb 3, 2026

I am not sure if DSO icons or even textures need any special treatment, I think they are not in icosaeder zones. Do they also disappear?

Concerning the Moon, I just don't understand why aberration should not be applied here. Is it integrated to the usual ephemeris? But what really needs to be done w.r.t. occultations is sketched in #1959 and #1924.

@Atque
Copy link
Contributor

Atque commented Feb 3, 2026

Yes, I think the solution to keep occultation timings was to disable it for the Moon as seen from Earth. This suggests the ephemeris has aberration applied to the Moon already. I can't see a difference between DE440/441 and VSOP87, so either all of them have integrated aberration for the Moon (but not planets apparently, which appears to be weird), or the Stellarium code applies it somewhere else.

@henrysky
Copy link
Contributor Author

henrysky commented Feb 4, 2026

I am not sure if DSO icons or even textures need any special treatment, I think they are not in icosaeder zones. Do they also disappear?

Yes they are also disappearing, see below

Screen.Recording.2026-02-03.at.7.10.32.PM.mov
@Atque
Copy link
Contributor

Atque commented Feb 4, 2026

Some kind of clipping that needs to be extended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants