gui: heatmap chip dependency#9771
Open
osamahammad21 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Open
gui: heatmap chip dependency#9771osamahammad21 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
osamahammad21 wants to merge 2 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the heatmap data source to depend on dbChip instead of dbBlock, which is a good generalization. The changes are applied consistently across multiple files. I found one potential critical issue: a null pointer dereference in HeatMapDataSource::getBounds(). I've added a comment with a suggested fix. Other than that, the changes look good.
Contributor
| clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: osamahammad21 <osama21@aucegypt.edu>
Contributor
| clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.