grt: refactor FastRouteCore files#9785
Open
openroad-ci wants to merge 7 commits intoThe-OpenROAD-Project:masterfrom
Open
grt: refactor FastRouteCore files#9785openroad-ci wants to merge 7 commits intoThe-OpenROAD-Project:masterfrom
openroad-ci wants to merge 7 commits intoThe-OpenROAD-Project:masterfrom
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
…ROAD into grt_refactor
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a series of refactoring changes across multiple files in the FastRouteCore. The main changes include removing duplicated code by introducing lambda functions and a helper function, replacing C-style casts with static_cast, and using references instead of raw pointers where applicable. These changes significantly improve code readability, maintainability, and adherence to modern C++ practices. The logic remains equivalent, and the changes do not appear to affect functionality. Overall, this is a great set of improvements to the codebase.
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Contributor
| clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Contributor
| clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates on multiple FastRouteCore files, including:
The updates should not affect any functionality.