Skip to content

Created Template resolving issue #165 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Created Template resolving issue #165 #172

wants to merge 2 commits into from

Conversation

@MukundLadani
Copy link

@MukundLadani MukundLadani commented Oct 2, 2022 •
edited
Loading

Template for PR

Closes #165.

Changes

  • Added PR template
@MukundLadani
Created Template
cab9423 
Template for PR
Panquesito7
Panquesito7 requested changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR template must be added in the .github directory, with the name PULL_REQUEST_TEMPLATE.md. Let us know if you need any help with doing that! Thank you. 🙂
@MukundLadani
Required Changes Done!
ded9f0d 
Changed name and location of file
@MukundLadani MukundLadani requested review from Panquesito7 and removed request for AnupKumarPanwar, ashwek and vbrazo October 2, 2022 20:25
@MukundLadani
Copy link
Author

MukundLadani commented Oct 6, 2022 •
edited
Loading

The PR template must be added in the .github directory, with the name PULL_REQUEST_TEMPLATE.md. Let us know if you need any help with doing that! Thank you. 🙂

@Panquesito7, I have made the required changes please accept PR. If there are no further changes accept it with label "HACKTOBERFEST ACCEPTED" else let me know the changes.
appgurueu
appgurueu requested changes Oct 6, 2022
View reviewed changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this is way too low quality to be useful in its current state. I would consider closing this PR.
@MukundLadani
Copy link
Author

MukundLadani commented Oct 6, 2022

I'm afraid this is way too low quality to be useful in its current state. I would consider closing this PR.

Let me know how could I increase the quality and its usefulness. And then if you can merge this PR after changes.
@appgurueu
Copy link
Collaborator

appgurueu commented Oct 6, 2022

This PR must be redone entirely.
@appgurueu appgurueu closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement

3 participants

@MukundLadani @appgurueu @Panquesito7