Skip to content

Conversation

@ngtduc693
Copy link
Contributor

@ngtduc693 ngtduc693 commented Oct 24, 2024

Implemented a triangulation algorithm to calculate your position based on distances from three base stations.

image

  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Comments in areas I changed are up to date
  • I have added comments to hard-to-understand areas of my code
  • I have made corresponding changes to the README.md
@ngtduc693
Copy link
Contributor Author

Passed all of the unit test

image

@ngtduc693 ngtduc693 marked this pull request as ready for review October 24, 2024 18:17
@ngtduc693 ngtduc693 requested a review from siriak as a code owner October 24, 2024 18:17
@codecov
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (013a6b9) to head (e76452e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #489 +/- ## ========================================== - Coverage 95.08% 95.03% -0.06%  ========================================== Files 257 258 +1 Lines 10669 10697 +28 Branches 1503 1504 +1 ========================================== + Hits 10145 10166 +21  - Misses 400 405 +5  - Partials 124 126 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@siriak siriak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@siriak siriak merged commit b19d093 into TheAlgorithms:master Oct 25, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants