build: bump Node version pins for loong64 and riscv64#2760
Open
CSharperMantle wants to merge 1 commit intoVSCodium:masterfrom
Open
build: bump Node version pins for loong64 and riscv64#2760CSharperMantle wants to merge 1 commit intoVSCodium:masterfrom
CSharperMantle wants to merge 1 commit intoVSCodium:masterfrom
Conversation
Contributor
| I think we should update the pins to "22.21.1" instead of removing them since unofficial-builds.nodejs.org doesn't seem to get up-to-date builds regularly https://unofficial-builds.nodejs.org/download/release/v22.21.1/ |
Author
Very reasonable. I'll soon update the patch. |
Member
| Yes, pin the version. If not pinned, it will try to use |
Currently, we lock the Node version to 20.16.0. This is reasonable at introduction time. However, the VSCode upstream is now using features that are only present in newer versions of Node. Meanwhile, pre-built binaries for v22.21.1 are already available. It is probably time to bump these outdated pins. These pins are kept rather than removed because the binaries are uploaded irregularly, and we shouldn't assume that future updates would be pushed in time. Fixes: VSCodium#2759 Suggested-by: darkyzhou <7220778+darkyzhou@users.noreply.github.com> Link: https://unofficial-builds.nodejs.org/download/release/v22.21.1/
CSharperMantle force-pushed the fix-node-version-rvla64 branch from 32a0c36 to 5253861 Compare CSharperMantle changed the title This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the outdated Node.js version pin for loong64 and riscv64, since the specified repository now ships pre-built binaries for these architectures of v22.21.1.
Fixes #2759.