This repository was archived by the owner on Sep 24, 2018. It is now read-only.
Prevent PHP error notice when &filter isn't an array #1734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The value is still set if `&filter` is passed, but `array_merge()` will error if `$request['filter']` isn't an array.
Member Author
| @WP-API/amigos #reviewmerge |
danielbachhuber added a commit that referenced this pull request Nov 17, 2015
Only process `filter` when it's an array
danielbachhuber changed the title filter when it's an arrayfilter isn't an array danielbachhuber changed the title filter isn't an array&filter isn't an array 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The value is still set if
&filteris passed, butarray_merge()willerror if
$request['filter']isn't an array.From #1733