List Block: Add custom spacing to the list block #27511
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
scruffian requested review from ajitbohra, chrisvanpatten, mkaz and talldan as code owners 53 tasks
| Size Change: +56 B (0%) Total Size: 1.19 MB
ℹ️ View Unchanged
|
scruffian force-pushed the add/spacing-to-list-block branch from af79bb3 to 95ea883 Compare scruffian added the Global Styles 
Member
| @scruffian Do the dimensions supports cover what you need? E.g., in "spacing": { "padding": true },We can control things pretty well.
Also the option to add |
Contributor
| I think we can close this one, unless there's more to this from @scruffian. |
Contributor Author
| Yeah this is stale. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Adds custom spacing settings to the list block.
This also fixes a bug in the box control component. When a list block is saved, only the set padding value is saved (left: 40px). The others are removed - this means when we check for mixed values we need to also check that there are 4 values, otherwise the check can return false just because the value match even though there's less than 4.
How has this been tested?
Tested in TT1 Blocks
Screenshots
Types of changes
New feature
Checklist: