- Notifications
You must be signed in to change notification settings - Fork 4.6k
Hide Post Date toolbar when child of Query in contentOnly mode #71707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Size Change: +8 B (0%) Total Size: 1.94 MB
ℹ️ View Unchanged
|
| Flaky tests detected in 73bcbb3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/17784405772
|
ramonjd left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described.
Makes sense to minimize design tools in a patterns + content only world = leave the design decisions to the pattern creators.
| } | ||
| is12Hour={ is12HourFormat( | ||
| siteTimeFormat | ||
| { ( blockEditingMode === 'default' || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional readability change by extracting conditions:
const canShowBlockControls = blockEditingMode === 'default' || ! isDescendentOfQueryLoop; const canShowDatePicker = displayType !== 'modified' && ! isDescendentOfQueryLoop;| The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Addresses some concerns around editability of Query children in contentOnly mode. See this comment.
Testing Instructions
It might be nice to have the block settings (or at least the link to post option) available in contentOnly mode but that's probably part of a wider inspector-related change: