Remove broken content only settings menu items feature #72470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
talldan added [Feature] Blocks 
| Size Change: -698 B (-0.03%) Total Size: 2.17 MB
ℹ️ View Unchanged
|
| Flaky tests detected in 085088a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/18645116813
|
Contributor
andrewserong left a comment
andrewserong left a comment There was a problem hiding this comment.
I like the idea of the removal! Looks like there's just some CSS here that could be removed, too?
| The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor Author
Good catch, now removed! |
andrewserong approved these changes Oct 21, 2025
Contributor
andrewserong left a comment
andrewserong left a comment There was a problem hiding this comment.
Looking good, each of the cases in the PR description are testing well (no block settings unexpectedly showing), and in regular usage the block settings menu shows as it should.
LGTM! 🚀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
Removes the block settings menu items that were previously introduced in #61127.
Why?
Happy to be told otherwise, but from my testing in trunk, these menu items are never shown. The blocks that might have had these options shown no longer have a block settings menu at all, so there's no way for the option to show.
The one time I was able to trigger the option was in my WIP PR #72044, where it looked very buggy, and didn't behave as expected.
Given the feature hasn't been working for some time (though I'm not sure how long), and no one has complained, I think it's probably best to remove it.
How?
Delete the code
Testing Instructions
There's not really anything to test as it didn't work anyway, but if you want to test that it still doesn't work after the feature is removed here's some steps:
Templates
Synced patterns
Content Only Template Lock
"templateLock":"contentOnly"attribute to the group