Add Upload button to experimental media modal and always allow multiple uploads #73125
+47 −5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tellthemachines requested review from aaronrobertshaw, andrewserong, fcoveram, ramonjd and talldan tellthemachines added [Type] Enhancement 
| Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
| Size Change: +185 B (+0.01%) Total Size: 2.41 MB
ℹ️ View Unchanged
|
| The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| Flaky tests detected in f728de0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19251181657
|
tellthemachines force-pushed the try/media-modal-uploads branch from d8ded50 to a1ff8e0 Compare 
ramonjd approved these changes Nov 11, 2025
Member
ramonjd left a comment
ramonjd left a comment There was a problem hiding this comment.
✅ Buttons works!
✅ I can upload one or multiple images using the file selector or by dragging and dropping
LGTM
Thanks for updating!
| const filesArray = Array.from( files ); | ||
| handleUpload( { | ||
| allowedTypes, | ||
| filesList: filesArray, |
Member
There was a problem hiding this comment.
Not a blocker, for another PR if you want. Looks like onUpload and uploadMedia both support onError - just thinking for when folks try to upload videos or other non-allowed files.
Member
| I looked at the static lint error but all I could see in the logs was No idea what it's complaining about. I kicked it off again 🤞🏻 |
Contributor Author
| Thanks for reviewing @ramonjd ! Yeah I don't know what's wrong with the linter. It has been failing consistently on all runs, even after a rebase 🤷 |
Contributor
| It looks like it was It's very subtle in the logs as it doesn't say error, but exit code 1:  |
Member
Good spotting! |
Contributor Author
| Oh nice, thanks Andy! Lol that all our automated tools and GH AI helper were utterly useless at identifying the actual problem. |
Contributor
| I followed the testing instructions steps and don't see the upload button.  And when dropping multiple files, it only works when I drop a single file. dropping.single.and.multiple.files.mp4 |
Contributor Author
| @fcoveram have you tried testing on the latest trunk? The multi-upload issue should be fixed and the upload button should be in place. |
Contributor
| I was trying from a testing site I have, but I tried in the PR runner and everything works correctly ✨ Sorry the confusion. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What?
Starts addressing #73085.
Adds an "upload media" button to the media modal, and also adjusts the Dropzone logic to always allow dropping multiple files regardless of the modal's
multipleproperty.Testing Instructions