- Notifications
You must be signed in to change notification settings - Fork 4.6k
Patterns: Change the icon and label for pattern section to use the pattern icon and name #73203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Size Change: +130 B (+0.01%) Total Size: 2.49 MB
ℹ️ View Unchanged
|
| Flaky tests detected in 49a95a5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19299574308
|
ramonjd left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the direction, thanks for getting it up! I tested with theme and user patterns. There were no errors when I deleted a pattern in the site admin and refresh the page.
| Before | After |
|---|---|
![]() | ![]() |
How do you think we should handle blocks with "templateLock":"contentOnly" and template parts? The icons in the list view/tool bar/inspector don't match.
| templateLock | Header |
|---|---|
![]() | ![]() |
Also, not for this PR but a general question: when two blocks are selected we show "n blocks" in the sidebar. Not a biggie really.
| The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
49a95a5 to bb25d87 Compare
Good point. I removed the icons from template parts and contentOnly locked blocks. |
296cde4 to b7cded8 Compare
ramonjd left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Nice one, I think this follows @fcoveram's instinct too. |





What?
Changes the block icon, name and description to be pattern icons/description, for patterns that are sections.
From #72574
Why?
This helps to consolidate the behaviour were adding to section blocks, by updating the UI to treat patterns as blocks in their own right.
How?
Add exceptions for section blocks
Testing Instructions
Screenshots or screencast