add entity filter for allay#721
Merged
Alexander01998 merged 2 commits intoWurst-Imperium:masterfrom Mar 24, 2023
DrMaxNix:master
Merged
add entity filter for allay#721Alexander01998 merged 2 commits intoWurst-Imperium:masterfrom DrMaxNix:master
Alexander01998 merged 2 commits intoWurst-Imperium:masterfrom
DrMaxNix:master
Conversation
|
|
ThisTestUser added a commit to ThisTestUser/Wurst7 that referenced this pull request Feb 25, 2023
Merged
Contributor Author
| Just out of curiosity: Will this PR be merged some day or am I missing something? |
Alexander01998 added type:enhancement 
Alexander01998 approved these changes Mar 24, 2023
Member
Alexander01998 left a comment
Alexander01998 left a comment There was a problem hiding this comment.
Hi, thanks for your contribution. Sorry for the delay in reviewing this PR. I think your code looks good and it makes sense to add an entity filter for allays. I have now tested it locally and it works as expected. I will merge this right away. Thanks again for your interest and patience.
Alexander01998 added a commit that referenced this pull request Mar 24, 2023
Alexander01998 added the status:merged This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit adds an entity filter for allays, as they are currently not included by any other filter.