Medical Core - Make second chance deactivation timeout configurable#289
Open
denispol wants to merge 2 commits intoacemod:medical/add-circulationfrom
Open
Medical Core - Make second chance deactivation timeout configurable#289denispol wants to merge 2 commits intoacemod:medical/add-circulationfrom
denispol wants to merge 2 commits intoacemod:medical/add-circulationfrom
Conversation
denispol force-pushed the medical/refactor-fall-damage branch from cea4839 to a4698e6 Compare 
…ate timestamp logic
denispol force-pushed the medical/refactor-fall-damage branch from a4698e6 to 002924a Compare 
Kexanone added kind/enhancement Kexanone changed the title 
Member
| Looks good, but this PR doesn't really need circulation as dependency, so could you instead fork from master and cherry-pick the changes there? Otherwise we won't be able to merge this to master until circulation got merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small opportunistic refactor I did while working on the second chance logic to improve configurability and code reuse.
When merged this pull request will:
m_iSecondChanceDeactivationTimeoutMs).HandleAnimatedFallDamageandHandleRagdollFallDamageinto a newACE_Medical_RecordFallDamageTime()helper method.Requires: