Skip to content

Balistics, SmallArms - Fix 9mm magazines Displaynames and Descriptions#10863

Merged
PabstMirror merged 9 commits intoacemod:masterfrom
Apricot-ale:pistolemagazione
Apr 18, 2025
Merged

Balistics, SmallArms - Fix 9mm magazines Displaynames and Descriptions#10863
PabstMirror merged 9 commits intoacemod:masterfrom
Apricot-ale:pistolemagazione

Conversation

@Apricot-ale
Copy link
Contributor

@Apricot-ale Apricot-ale commented Apr 12, 2025

When merged this pull request will:

  • Fix ACE 16Rnd 9x19 magazine description was the display name for the non-existent 30Rnd 9x19 magazine.
  • Fix BIS 16rnd 9x21 tracer magazine display name shown as 16Rnd despite being 17Rnd by ACE.
  • Add missing FNX-45 magazine displaynameshort. That is displayed like other .45 magazines.

Note: The localization is based on what we copied from the game, so it should be fine.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.
Stop converting 16 round BIS pistol magazines to 17 round magazines and add a dedicated 17 round ACE pistol magazine.
add missing .45
@Drofseh
Copy link
Contributor

Drofseh commented Apr 12, 2025

the changes to magazines[] and magazineWell[] will likely break a ton of loadouts, including vanilla ones.

@Mike-MF
Copy link
Member

Mike-MF commented Apr 12, 2025

Changing the magazine count back to 16 after 11 years doesn't really make sense.

@Apricot-ale
Copy link
Contributor Author

so I'll remove 17 rnd change

@Apricot-ale Apricot-ale changed the title Balistics, SmallArms - Change 9mm 17rnd magazines Balistics, SmallArms - Fix 9mm 17rnd magazines displayname and descriptions Apr 13, 2025
@Apricot-ale Apricot-ale changed the title Balistics, SmallArms - Fix 9mm 17rnd magazines displayname and descriptions Balistics, SmallArms - Fix 9mm magazines Displaynames and Descriptions Apr 13, 2025
@Apricot-ale
Copy link
Contributor Author

@Mike-MF
The PR content and description changed.
Check and leave a review please.

@Apricot-ale Apricot-ale requested a review from Mike-MF April 17, 2025 01:17
@Mike-MF Mike-MF added the kind/enhancement Release Notes: **IMPROVED:** label Apr 17, 2025
@Mike-MF Mike-MF added this to the 3.20.0 milestone Apr 17, 2025
@PabstMirror PabstMirror merged commit 3f494d0 into acemod:master Apr 18, 2025
3 checks passed
@Apricot-ale Apricot-ale deleted the pistolemagazione branch May 4, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

4 participants