Fetch the submodules in readthedocs with ci_fetch_deps.py #6400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dhalbert approved these changes May 14, 2022
Collaborator
dhalbert left a comment
dhalbert left a comment There was a problem hiding this comment.
Thanks for working on this!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #6399
Make Readthedocs's own build process use ci_fetch_deps.py to checkout the submodules in the same way the CI does. That doesn't make github docs CI and the RTD build use the exact same steps (which they didn't already), but submodule dependencies are now in a single place.
Note: the previous version caused an error because RTD's submodule clause requires exact submodules, it doesn't do parent directories like
frozenor patterns likefrozen/*.