- Notifications
You must be signed in to change notification settings - Fork 207
feat: add s2 static colors #4315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 728523e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
722d00e to 507c44a Compare Adds the Spectrum 2 static colors from Spectrum Tokens via manual definitions
507c44a to bb8aa0a Compare 📚 Branch previewPR #4315 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4315/index.html. |
5cb44af to b0a430e Compare File metricsSummaryTotal size: 2.26 MB* Table reports on changes to a package's main file. tokens
* An ASCII character in UTF-8 is 8 bits or 1 byte. |
| "@spectrum-css/tokens": minor | ||
| --- | ||
| | ||
| Manually adds the s2 static color values from [Spectrum Tokens](https://github.com/adobe/spectrum-tokens/blob/04cf6eb95ece7f3320e0e2babd6a51db8edfc950/packages/tokens/src/color-palette.json#L6491) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe dumb Q, but should this be https://github.com/adobe/spectrum-tokens/blob/main/packages/tokens/src/color-palette.json#L6491
I'm not sure if that blob hash is main? Or if it's different? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. It's the SHA from this point in time on main over there. I figured that if we ever needed to trace back to where these came from, at least we'll have some marker since these aren't directly associated with a Spectrum Tokens release.
Description
Adds the Spectrum 2 static colors from Spectrum Tokens via manual definitions.
Specifically, the values defined here match (at the time of authorship) the Spectrum Tokens static color values here.
These are considered additive to the system and should not cause any visual differences.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
Regression testing
Validate:
Screenshots
To-do list