Skip to content

Conversation

@pfulton
Copy link
Collaborator

@pfulton pfulton commented Nov 18, 2025

Description

Adds the Spectrum 2 static colors from Spectrum Tokens via manual definitions.

Specifically, the values defined here match (at the time of authorship) the Spectrum Tokens static color values here.

These are considered additive to the system and should not cause any visual differences.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.
  1. If components have been modified, VRTs have been run on this branch:
  • VRTs have been run and looked at.
  • Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

To-do list

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2025

🦋 Changeset detected

Latest commit: 728523e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@spectrum-css/tokens Minor
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pfulton pfulton force-pushed the feat--add-s2-static-colors branch from 722d00e to 507c44a Compare November 18, 2025 15:41
Adds the Spectrum 2 static colors from Spectrum Tokens via manual definitions
@pfulton pfulton force-pushed the feat--add-s2-static-colors branch from 507c44a to bb8aa0a Compare November 18, 2025 15:43
@pfulton pfulton added the run_vrt For use on PRs looking to kick off VRT label Nov 18, 2025
@pfulton pfulton requested a review from a team November 18, 2025 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

📚 Branch preview

PR #4315 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4315/index.html.

@pfulton pfulton force-pushed the feat--add-s2-static-colors branch from 5cb44af to b0a430e Compare November 18, 2025 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2025

File metrics

Summary

Total size: 2.26 MB*
Total change (Δ): 🔴 ⬆ 9.57 KB (0.42%)

Table reports on changes to a package's main file.

tokens

Filename Head Minified Gzipped Compared to base
css/dark-vars.css 48.31 KB - - -
css/global-vars.css 48.98 KB - - 🔴 ⬆ 4.79 KB
css/index.css 210.11 KB - - 🔴 ⬆ 4.79 KB
css/large-vars.css 32.08 KB - - -
css/light-vars.css 48.27 KB - - -
css/medium-vars.css 32.24 KB - - -
json/tokens.json 290.06 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.
"@spectrum-css/tokens": minor
---

Manually adds the s2 static color values from [Spectrum Tokens](https://github.com/adobe/spectrum-tokens/blob/04cf6eb95ece7f3320e0e2babd6a51db8edfc950/packages/tokens/src/color-palette.json#L6491)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe dumb Q, but should this be https://github.com/adobe/spectrum-tokens/blob/main/packages/tokens/src/color-palette.json#L6491

I'm not sure if that blob hash is main? Or if it's different? :)

Copy link
Collaborator Author

@pfulton pfulton Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out. It's the SHA from this point in time on main over there. I figured that if we ever needed to trace back to where these came from, at least we'll have some marker since these aren't directly associated with a Spectrum Tokens release.

@pfulton pfulton added do not merge A flag for a branch indicating it should not be merged. and removed ready-for-review labels Nov 19, 2025
@pfulton pfulton closed this Nov 21, 2025
@pfulton pfulton deleted the feat--add-s2-static-colors branch November 21, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge A flag for a branch indicating it should not be merged. run_vrt For use on PRs looking to kick off VRT

5 participants