Skip to content

Beta Zip Loading#180

Open
workinKeith wants to merge 3 commits intoaduros:masterfrom
workinKeith:zip
Open

Beta Zip Loading#180
workinKeith wants to merge 3 commits intoaduros:masterfrom
workinKeith:zip

Conversation

@workinKeith
Copy link
Contributor

Manifest can now load zip files. AssetPackLoader saves each file in
the zip as a blob and loads normally.

  • only tested so far with png, jpeg, mp3, ogg, fnt, and xml
  • only works if blob is supported
Manifest can now load zip files. AssetPackLoader saves each file in the zip as a blob and loads normally. - only tested so far with png, jpeg, mp3, ogg, fnt, and xml so far - only works if blob is supported
@markknol
Copy link
Contributor

Cool, will this work on a Flash target too?

@workinKeith
Copy link
Contributor Author

Nope, but that's an easy change! I'll commit one with Flash support tomorrow.

Added flash support. FlashAssetPackLoader loads the zip file using a URLLoader. Each file in the zip is loaded in the same way as a regular file except it uses bytes instead of a URLRequest - tested with png, jpg, mp3, xml, and fnt
Added tar loading to flash and html5. Works similar to zip loading except it uses format.tar.Reader - note: I'm not sure why loading a tar entry in HtmlAssetPackLoader doesn't work as an inline function
@anissen
Copy link
Contributor

anissen commented May 1, 2014

@aduros Any thoughts on whether this should be merged in or not?

@workinKeith
Copy link
Contributor Author

This is a little under-tested. I'd call it "Beta" quality level. It works in our limited tests, but we never pushed it to 100% because for our target devices it didn't wind up improving load times (unpacking took longer than downloading).

It's an open question if that's preferable to having no ZIP/TAR support.

@aduros
Copy link
Owner

aduros commented May 3, 2014

Yeah, Keith and I talked about this offline when he was working on it. Since it didn't show a improvement, I'd rather avoid the maintenance cost of merging it.

It's possible that it could be optimized and retested later, but I don't think anyone's looking at it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants