Initial OpenBSD support, basically the same as pull request #148#160
Open
nevun wants to merge 76 commits intoagl:masterfrom
Open
Initial OpenBSD support, basically the same as pull request #148#160nevun wants to merge 76 commits intoagl:masterfrom
nevun wants to merge 76 commits intoagl:masterfrom
Conversation
Mostly just copied code to _bsd.go sys_bsd.go contains some code for checking that swap encryption is toggled and that there is a tmpfs partition mounted, basically just porting what sys_darwin.go does.
Ideally this should quote only the selected text if any text is selected in the message viewer when the user presses reply. At least that's how my email client works. I assume Go initalizes the two local varialbes I eliminated to zero, but I thought it looked cleaner to initalize them explicitly and and set them if inReplyTo is set. <shrug>
The old value (2048) was just a sanity check against storing a huge number of keys for missing messages, but was still very large. This seems like a more reasonable number.
…lied further below, but it is good to clear up confusion as early as possible.
The exit instructions were suggesting that server operators set the ORPort, which is probably a bad idea.
This commit contains changes to the generic parts of the codebase to support the native, OS X GUI. The GUI isn't ready yet and the bulk of it will live in a branch for now.
Previously this would cause the GUI client to crash if a contact was selected while a revocation notice arrived. Fixes agl#96.
Previously an EOF from the terminal would cause one of the goroutines to busy-loop until another recorded the error and exited the process.
Move indentForReply, which is now common between cli and gui, into client.go
If a key-exchange failed then isPending would be cleared but the expected elements of the contact wouldn't have been filled out. This caused a crash during the next save() call.
In order to avoid typos in shared secrets, the generated shared secrets now have a special form that includes a checksum. Old versions of the code will continue to work fine with them but, from this change on, the cli and gui will reject shared secrets that have the special prefix ("r!" or "r[") but don't have a valid checksum. The second form of shared secret (beginning "r[") is not generated yet but causes the scrypt step to be skipped. This is laying foundations for the future where these values can be generated. Fixes issue agl#100.
Also, update the error message for attaching a file that is too large so that the unimplemented command, save-encrypted, isn't mentioned.
"notpm" causes TPM support to be disabled. This removes the need to install libtspi.
If ~/Persistent exists then the default statefile location will be a file called ".pond" inside that directory.
In order to reduce (further) the reordering of messages, this change extends the server to store the delivery in the filename of messages. Previously the mtime was used, but that only has single-second fidelity. The server will automatically update old message filenames to the new scheme at startup.
This code will be removed at some point so this change highlights contacts with whom an old ratchet is being used. In order to ensure that a contact keeps working, it's neccessary to confirm that the contact is running an up-to-date version of the client and to perform a new key exchange with them.
Apparently APT has a bug with the slash notation for installing packages from specific suites.
This change causes error messages from the ratchet code to be surfaces to the user in the contact log. This is to help debug agl#124.
When installing on Ubuntu 14.04, Go 1.3 will need to be installed from source since Ubuntu's is too old now. (Noted in agl#123.) See https://golang.org/doc/go1.3#cgo for details of the changes.
Does not resolve the existence of DELIVERY_SIGNATURE_INVALID messages in agl#134
… under TBB. There was an issue because PANDA runs over tor even in developer mode, but TBB uses port 9150 rather than the default tor port 9050. Allow tor to be used by PANDA when running in developer mode Oops
(Roughly based on burdges@d41c34c)
Conflicts: client/client.go panda/panda.go server/server.go server/server_test.go
…the same as /tmp on OpenBSD nowadays
We must call moveContactsMessagesToEndOfQueue if we encounter trouble contacting a pond server while sending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only difference to #148 is really the filesystem parsing. I thought it was easier and made for clearer code to use /sbin/mount and parse its output. shrug. There are some other small differences since I forked a while ago and made my changes independently of dajohi.
Would be nice to get any of these pull requests in so a straight forward port could be made in OpenBSD.