Fix Nondeterministic Ordering in Tests Part 1 #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@ ## master #15 +/- ## ========================================= Coverage 82.32% 82.32% Complexity 1113 1113 ========================================= Files 91 91 Lines 4148 4148 Branches 554 554 ========================================= Hits 3415 3415 Misses 508 508 Partials 225 225 Continue to review full report at Codecov.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #15 +/- ## ========================================= Coverage 82.32% 82.32% Complexity 1113 1113 ========================================= Files 91 91 Lines 4148 4148 Branches 554 554 ========================================= Hits 3415 3415 Misses 508 508 Partials 225 225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
18 tests from com.alibaba.innodb.java.reader.sk.SimpleSkTableReaderTest are flaky.
If java.lang.Object.getDeclaredFields() returns the fields in a different order multiple tests could fail. This PR ensures that the tests pass even if the order changes.
To guarantee the ordering of com.alibaba.innodb.java.reader.getAllRows(...), I've added annotations, PR: #14, to Employee class and Department class to sort the fields by their annotated values.
As per https://docs.oracle.com/javase/8/docs/api/java/lang/Class.html#getDeclaredFields--
"The elements in the returned array are not sorted and are not in any particular order."