- Notifications
You must be signed in to change notification settings - Fork 50
Closed
Labels
bugSomething isn't workingSomething isn't workingpure python version onlyThe bug does not exist on the Rust versionThe bug does not exist on the Rust version
Description
When the next multiplier is a million, following billions, it is not handled correctly. It is not detected as an expected valid multiplier. There is a "TODO" comment in the related code, I suspect it is about this issue.
It doesn't happen with Spanish because in Spanish billion is basically "thousand millions".
If the next multiplier following billions is a thousand, it works fine, because 1000x1000=1,000,000 < 1 billion.
For now, I add the following check to the end of is_coef_appliable() method, before returning False, it works fine for me now:
if coef > self.grp_val and coef * self.grp_val < self.n000_val: return True It seems reasonable to me, but I may not be able to consider all possible cases, and for different languages. Just a suggestion for the time being.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpure python version onlyThe bug does not exist on the Rust versionThe bug does not exist on the Rust version