Skip to content

Retry auth URL lookup without docker credentialhelper workaround#939

Merged
wagoodman merged 1 commit intomainfrom
docker-config-auths-fix
Apr 6, 2022
Merged

Retry auth URL lookup without docker credentialhelper workaround#939
wagoodman merged 1 commit intomainfrom
docker-config-auths-fix

Conversation

@wagoodman
Copy link
Contributor

Fixes #936

See anchore/stereoscope#122 for the specific fix in stereoscope

Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman wagoodman requested a review from a team April 6, 2022 16:11
@wagoodman wagoodman self-assigned this Apr 6, 2022
@wagoodman wagoodman enabled auto-merge (squash) April 6, 2022 16:18
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Benchmark Test Results

Benchmark results from the latest changes vs base branch
name old time/op new time/op delta ImagePackageCatalogers/ruby-gemspec-cataloger-2 1.50ms ± 7% 1.13ms ± 1% -24.72% (p=0.008 n=5+5) ImagePackageCatalogers/python-package-cataloger-2 3.76ms ± 2% 2.87ms ± 0% -23.71% (p=0.016 n=5+4) ImagePackageCatalogers/php-composer-installed-cataloger-2 1.21ms ± 1% 0.93ms ± 0% -22.80% (p=0.008 n=5+5) ImagePackageCatalogers/javascript-package-cataloger-2 815µs ± 3% 625µs ± 0% -23.38% (p=0.008 n=5+5) ImagePackageCatalogers/dpkgdb-cataloger-2 963µs ± 3% 738µs ± 1% -23.31% (p=0.008 n=5+5) ImagePackageCatalogers/rpmdb-cataloger-2 862µs ± 3% 656µs ± 1% -23.88% (p=0.008 n=5+5) ImagePackageCatalogers/java-cataloger-2 16.3ms ± 3% 12.1ms ± 1% -25.75% (p=0.008 n=5+5) ImagePackageCatalogers/apkdb-cataloger-2 1.58ms ± 0% 1.17ms ± 2% -25.84% (p=0.008 n=5+5) ImagePackageCatalogers/go-module-binary-cataloger-2 2.71µs ± 2% 2.06µs ± 1% -24.05% (p=0.008 n=5+5) name old alloc/op new alloc/op delta ImagePackageCatalogers/ruby-gemspec-cataloger-2 184kB ± 0% 184kB ± 0% ~ (p=0.222 n=5+5) ImagePackageCatalogers/python-package-cataloger-2 895kB ± 0% 896kB ± 0% +0.08% (p=0.032 n=5+5) ImagePackageCatalogers/php-composer-installed-cataloger-2 196kB ± 0% 196kB ± 0% +0.23% (p=0.008 n=5+5) ImagePackageCatalogers/javascript-package-cataloger-2 140kB ± 0% 140kB ± 0% ~ (p=0.548 n=5+5) ImagePackageCatalogers/dpkgdb-cataloger-2 175kB ± 0% 175kB ± 0% +0.25% (p=0.008 n=5+5) ImagePackageCatalogers/rpmdb-cataloger-2 163kB ± 0% 163kB ± 0% +0.14% (p=0.016 n=5+5) ImagePackageCatalogers/java-cataloger-2 3.19MB ± 0% 3.18MB ± 0% ~ (p=0.095 n=5+5) ImagePackageCatalogers/apkdb-cataloger-2 1.24MB ± 0% 1.24MB ± 0% +0.05% (p=0.008 n=5+5) ImagePackageCatalogers/go-module-binary-cataloger-2 672B ± 0% 672B ± 0% ~ (all equal) name old allocs/op new allocs/op delta ImagePackageCatalogers/ruby-gemspec-cataloger-2 3.66k ± 0% 3.66k ± 0% ~ (all equal) ImagePackageCatalogers/python-package-cataloger-2 14.8k ± 0% 14.8k ± 0% ~ (p=0.151 n=5+5) ImagePackageCatalogers/php-composer-installed-cataloger-2 4.94k ± 0% 4.94k ± 0% ~ (p=1.000 n=5+5) ImagePackageCatalogers/javascript-package-cataloger-2 2.72k ± 0% 2.72k ± 0% ~ (all equal) ImagePackageCatalogers/dpkgdb-cataloger-2 3.93k ± 0% 3.93k ± 0% ~ (all equal) ImagePackageCatalogers/rpmdb-cataloger-2 4.01k ± 0% 4.01k ± 0% ~ (all equal) ImagePackageCatalogers/java-cataloger-2 52.2k ± 0% 52.1k ± 0% ~ (p=0.095 n=5+5) ImagePackageCatalogers/apkdb-cataloger-2 4.82k ± 0% 4.82k ± 0% ~ (all equal) ImagePackageCatalogers/go-module-binary-cataloger-2 15.0 ± 0% 15.0 ± 0% ~ (all equal) 
@wagoodman wagoodman merged commit 748cfbf into main Apr 6, 2022
@wagoodman wagoodman deleted the docker-config-auths-fix branch April 6, 2022 16:27
spiffcs added a commit that referenced this pull request May 2, 2022
* main: (31 commits) reduce noise of log output (#976) add version info and remove double config call (#977) Rename syft-id to package-id (#970) update to cyclonedx-go 0.5.2 (#971) refactor command package to remove globals and add dependency injection fix: #953 Derive language from pURL - https://github.com/anchore/syft… (#957) Fix typo in CPE-parsing error (#966) Preserve syft IDs on SBOM decode (#963) Update GitHub format package_url and correlator (#961) Ensure SPDXIDs are valid (#955) Auto-PR needs to run go mod tidy (#958) Add workflow for automatic PR for new stereoscope updates (#954) Minor readme update to correct format information (#948) Update spdx22json to only take uppercase checksum algorithm (#946) add additional vendors for springframework (#945) Add digest property to parent and nested java package metadata (#941) Update write permissions and log into ghcr.io for release (#942) Retry auth URL lookup without docker credentialhelper workaround (#939) Ensure that all cyclonedx components have bom-refs (#914) Additionally publish docker images to GHCR (#934) ... Signed-off-by: Christopher Phillips <christopher.phillips@anchore.com>
rigzba21 pushed a commit to rigzba21/syft that referenced this pull request May 5, 2022
…hore#939) Signed-off-by: rigzba21 <jonathan.velando01@gmail.com>
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants