Support PLY files with additional elements (e.g., SHARP camera data)#69
Open
ztffn wants to merge 1 commit intoantimatter15:mainfrom
Open
Support PLY files with additional elements (e.g., SHARP camera data)#69ztffn wants to merge 1 commit intoantimatter15:mainfrom
ztffn wants to merge 1 commit intoantimatter15:mainfrom
Conversation
This patch adds support for PLY files that contain additional elements beyond the standard vertex data, such as camera intrinsic/extrinsic matrices embedded by tools like Apple's SHARP. Changes: - Parse properties only within vertex elements, ignoring others - Limit DataView to exact vertex data size to prevent bounds errors - Maintain full backward compatibility with standard PLY files Fixes issues with PLY files from SHARP and other tools that embed camera or metadata elements in the PLY format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for PLY files that contain additional elements beyond the standard vertex data, such as camera intrinsic/extrinsic matrices embedded by tools like Apple's SHARP.
Currently, the viewer fails to load PLY files from SHARP and other tools that embed camera or metadata elements in the PLY format, showing 'offset is outside the bounds of the DataView' errors.
The fix parses properties only within vertex elements while ignoring additional elements, and limits the DataView to the exact vertex data size to prevent bounds errors. This maintains full backward compatibility with standard Gaussian splat PLY files.
Tested with both standard PLY files (which continue to work unchanged) and SHARP-generated PLY files (which now load successfully). No performance impact on existing functionality.