Add additional comment to clarify the minimal supported version of ou… #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tputing dependency tree in JSON fromat.
elharo reviewed Nov 13, 2024
Contributor
elharo left a comment
elharo left a comment There was a problem hiding this comment.
For myself, I prefer to focus the docs on the current version. I really don't care what was true several versions ago.
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java Outdated Show resolved Hide resolved
elharo reviewed Dec 31, 2024
| * If specified, this parameter will cause the dependency tree to be written using the specified format. Currently | ||
| * supported formats are: <code>text</code> (default), <code>dot</code>, <code>graphml</code>, <code>tgf</code> | ||
| * and <code>json</code>. | ||
| * and <code>json</code> (since 3.7.0). |
Contributor
There was a problem hiding this comment.
I don't know that we need this. It's implicitly the current version being described.
Member
There was a problem hiding this comment.
It is information in which version such feature was added - for me it is ok
slawekjaranowski approved these changes Jan 4, 2025
slawekjaranowski added the documentation 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…tputing dependen