Skip to content

Conversation

@mbien
Copy link
Member

@mbien mbien commented Nov 28, 2025

Upgrades the javac integration to nb-javac based on JDK 26b26.

This PR is based on a copy of the valhalla javac experiment #8995 but swaps the nb-javac dependency against staged nb-javac 26b26 based on https://github.com/lahodaj/nb-javac/commits/upgrade-jdk26/. It will be later updated to a nb-javac release from maven central.

manual testing:

closes #4470
closes #6822
closes #8722

@mbien mbien added this to the NB29 milestone Nov 28, 2025
@mbien mbien added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) JavaDoc [ci] enable java/javadoc tests and build-javadoc target ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Upgrade Library Library (Dependency) Upgrade and removed JavaDoc [ci] enable java/javadoc tests and build-javadoc target ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Nov 28, 2025
@mbien
Copy link
Member Author

mbien commented Nov 28, 2025

java.refactoring / EncapsulateFieldsTest.test219140() failure is interesting

the (unrelated) refactoring generates:

 private final transient_or_acc_varargs PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);

instead of:

 private final transient PropertyChangeSupport propertyChangeSupport = new java.beans.PropertyChangeSupport(this);

sounds like a change in a toString() of a modifier?

edit: fixed

@mbien mbien added the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Nov 28, 2025
@mbien mbien changed the title Upgrade nb-javac to JDK 26ea Upgrade nb-javac to JDK 26b26 Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Upgrade Library Library (Dependency) Upgrade

2 participants