Skip to content

Add NullOrEmpty and NullOrWhiteSpace overloads for ReadOnlySpan<char>#237

Merged
ardalis merged 6 commits intoardalis:mainfrom
KonH:feature/read_only_span_support
Feb 15, 2023
Merged

Add NullOrEmpty and NullOrWhiteSpace overloads for ReadOnlySpan<char>#237
ardalis merged 6 commits intoardalis:mainfrom
KonH:feature/read_only_span_support

Conversation

@KonH
Copy link
Contributor

@KonH KonH commented Oct 9, 2022

Related to #220

Copy link
Contributor

@Marvin-Brouwer Marvin-Brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some possible suggestions

@KonH
Copy link
Contributor Author

KonH commented Oct 10, 2022

It looks like all changes are made

@Marvin-Brouwer
Copy link
Contributor

The code looks great to me, I just spotted one last thing.
I see the extensions are in src/GuardClauses/GuardAgainstNullExtensions.cs but does that filename still make sense since there's no Null being guarded?

@Marvin-Brouwer
Copy link
Contributor

@ardalis I had a check on the PR, is anyone allowed to just approve it?
I can only find something about opening PR's in the contribution guide but not about approving them.

@Reapism
Copy link

Reapism commented Feb 15, 2023

This seems like a good addition to the library. Making an attempt at resurrecting this PR.

@ardalis ardalis merged commit 6d41101 into ardalis:main Feb 15, 2023
@ardalis
Copy link
Owner

ardalis commented Feb 15, 2023

Merged; will try to get a release out this month!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants