Open
Conversation
armink reviewed Jan 19, 2020
| struct sector_meta_data sector; | ||
| struct env_node_obj env; | ||
| }; | ||
| typedef struct env_iterator_obj *env_iterator_obj_t; |
Author
There was a problem hiding this comment.
sector_meta_data 这个类型没有在 ef_def.h里，如果迭代器定义在 ef_def.h里，一堆类型声明都要移过来
Owner
There was a problem hiding this comment.
- sector_meta_data
- sector_store_status_t
- sector_dirty_status_t
对应的都搬过去就好了
| | ||
| return empty_env; | ||
| } | ||
| static struct env_iterator_obj _g_env_iter_obj; |
Owner
There was a problem hiding this comment.
定义在 ef_def.h 后，迭代器就可以支持多实例模式，这里的定义也不需要了
对应的，这些 API 可能也不需要了 ef_env_iterator_to_first ef_env_iterator_now_name ef_env_iterator_now_value_len
你觉得呢？
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.