Added unit tests for the diagonal function #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
roaffix reviewed Mar 2, 2024
tests/test_diag.py Outdated
| # tests to include | ||
| # - if diagonal created is same shape as the input diagonal | ||
| # - if diagonal value is same value as input diagonal | ||
| # - if invalid diagonal is passed in |
Collaborator
There was a problem hiding this comment.
Is this comment necessary here?
Contributor Author
There was a problem hiding this comment.
deleted them in the new commit
Contributor Author
| @roaffix getting black and other formatting errors in manage_array.py. Should I go in and fix that file's formatting or leave it? |
…ry-python-wrapper into random_tests Pull in remote random branch changes
…on-wrapper into diag_tests
Collaborator
Its fine. I'll fix them all in some time |
roaffix approved these changes Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR introduces a suite of unit tests for lower.py located within the within the create_array directory. The primary functions in this file facilitate the creation of an an array with a specified diagonal, where this specified diagonal is passed in as an AFArray.
Diagonal: Ensures that the diagonal of the new array matches the shape and the value of of the original array given.
Diagonal Invalid Shape: Ensures that proper error checking occurs if a diagonal array is trying to be constructed from an array with incorrect dimensions (can only be 1D or 2D).