Open
Conversation
georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 3995cc8 to e545879 Compare 
georgehristov force-pushed the feature/introduce-aggregate-union-models branch 3 times, most recently from 3827e56 to 189782c Compare georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 189782c to 691d9bd Compare georgehristov force-pushed the feature/introduce-aggregate-union-models branch from 4c75866 to ee88bb5 Compare georgehristov changed the title 
mvorisek reviewed Jul 27, 2020
mvorisek reviewed Jul 27, 2020
mvorisek reviewed Jul 27, 2020
mvorisek reviewed Jul 27, 2020
mvorisek reviewed Jul 27, 2020
mvorisek requested changes Jul 27, 2020
DarkSide666 reviewed Jul 27, 2020
DarkSide666 reviewed Jul 27, 2020
DarkSide666 reviewed Mar 17, 2024
| $unionPaymentInvoice->addField('type'); | ||
| ``` | ||
| | ||
| A new field "type" has been added that will be defined as a static constant. |
Member
There was a problem hiding this comment.
What is "static constant" here? Minimal example would be good.
DarkSide666 requested changes Mar 17, 2024
Member
DarkSide666 left a comment
DarkSide666 left a comment There was a problem hiding this comment.
I didn't review codebase, but in documentation there are some errors to fix.
mvorisek requested changes Mar 17, 2024
Member
mvorisek left a comment
mvorisek left a comment There was a problem hiding this comment.
prevent accidental merge
impl. is still probably problematic and tests should be cleaned up
mvorisek reviewed May 4, 2024
| private function createUnionQuery(array $subqueries): Persistence\Sql\Query | ||
| { | ||
| $unionQuery = $this->getPersistence()->dsql(); | ||
| $unionQuery->mode = 'union_all'; |
Member
There was a problem hiding this comment.
subqueries must support order by, limit or double wrap then to workaround
mvorisek reviewed Sep 12, 2025
| $transaction = $this->createTransaction(); | ||
| | ||
| $this->assertSameSql( | ||
| 'select `name` `name` from `invoice` UNION ALL select `name` `name` from `payment`', |
Member
There was a problem hiding this comment.
1) Atk4\Data\Tests\Persistence\Sql\MaterializedArrayActionTest::testRenderMultipleRows Atk4\Data\Persistence\Sql\ExecuteException: An exception occurred while executing a query: ORA-01790: expression must have same datatype as corresponding expression query: 'select true "bool", -9223372036854775808 "int", -1.5E - 50 "float", '' "string" from "DUAL" union all select NULL, 9223372036854775807, 1.0123456789123E + 300, ' foo ' from "DUAL"' The ORA-01790 Oracle error is caused when one select selects null from untyped table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.