fix: updates to allow building the library Python 3.11 #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR addresses a bug that occurs when building the graph-notebook with Python3.11. The Porting to Python 3.11 summary calls out a change to global inline flags so that they can only be used at the start of a regular expression.
The existing code for converting globs -> regexes appends the
(?ms)modifier at the end of the pattern. This PR removes the multiline and dotall modifiers from the regex string template. Instead, it uses the multiline and dotall flags in the compile statement.This allows the
graph-notebooklibrary to, at a minimum, build with Python3.11By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.