Conversation
bee-san requested changes May 16, 2021
Owner
bee-san left a comment
bee-san left a comment There was a problem hiding this comment.
Looking good! Left some comments. Also:
- You need tests (both click and function)
- API documentation needs to be updated for this :-)
Contributor Author
| Should be all good :) |
Indent problem didn't go thrugh.
bee-san requested changes May 16, 2021
Owner
bee-san left a comment
bee-san left a comment There was a problem hiding this comment.
I also asked for click tests :)
Owner
| Lol I tried to fix your merge conflicts and it broke everything sorry |
amadejpapez reviewed May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Had some issues with getting this, I wanted it to remove all the hash types from the dict if it wasn't in the popular list but for some reason it would only remove a few, yet, if I did it the opposite way (making a new list and then appending) ones, it worked fine. Drove me nuts for a bit. Couldn't find any other cleaner way :(. - If you knew why it was doing this please tell me! :)