Crawl images and other HTML linked resources as well#103
Open
dramalho wants to merge 2 commits intobenpickles:mainfrom
Open
Crawl images and other HTML linked resources as well#103dramalho wants to merge 2 commits intobenpickles:mainfrom
dramalho wants to merge 2 commits intobenpickles:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small follow up to #102 where I was trying to figure out the best strategy to include
ActiveStorageattachments into the static build.TL;DR; I first tried to generate and copy the attachment files via a rake task but there are - to the best of my present knowledge - quite a few hoops to jump through to get the right final URL so that it matches what the markup expects, so much so that I think it's extremely error prone. The other option I explored was for
parklifeto merely collect more URLs and - maybe - get and save those files, which I ended up doing inUtils#scan_for_linksThe code is simple enough but I'm unsure what scenarios exist that might hamper this approach, so I though I would open a PR just the same as that makes discussion easier .. maybe :)