fix(auth): ensure getValue is properly awaited#48
Merged
Bekacru merged 1 commit intobetter-auth:mainfrom Jul 20, 2025
Merged
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor Author
| Just saw @hisyamnasir's #47 (checked opened issues but didn't check PRs so I missed this). My version runs them in parallel though, so will keep open as an alternative fix - just adding a note on duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic auth and custom auth does not work.
Turns out the
getValuefunction inauth.tsis not awaited. This means that, for example in basic auth, what's being sent is the base64 encoded version ofinstead of