Remove form field via keyboard

[pinussilvestrus]

Related to #437

Check it out via https://demo-437-remove-via-keyboard--camunda-form-playground.netlify.app/.

What immediately comes through: to make it fly, we'd need navigation via keyboard (cf. #173).

[pinussilvestrus]

I'd love to hear your feedback @Skaiir @vsgoulart @RomanKostka @christian-konrad

[pinussilvestrus]

We should probably simply limit the keyboard binding of the editor to the editor container (via keyboard config). It's currently binded to the document.

This could be handled in the camunda/form-playground integration.

[vsgoulart]

@pinussilvestrus I like it a lot! I would say this is a very power user feature, so I would give it a lower priority if we compare to other features. But if the implementation is very easy I think it's worth it to merge.

Do we have any shortcuts cheatsheet in the playground?

[pinussilvestrus]

Do we have any shortcuts cheatsheet in the playground?

I don't think so. We have a module that takes care of these. The playground itself doesn't have any other keyboard bindings (yet). The panel toggles are implemented in the Modeler products separately.

[pinussilvestrus]

Feedback via Slack from @Skaiir

If there is one thing I would say it's that it's maybe a little bit too easy for the deletion to get captured by the main window. Basically the editor is always active, and unless we're focusing something that will handle the keyboard input, the delete action will trigger. A good example of this problem can be seen when pressing delete when focusing a taglist tag.

[nikku]

From my point of view the overall interaction pattern (including playgrounds and stuff) is blocked by bpmn-io/diagram-js#661. To properly handle keyboard shortcuts we must be browser focus aware and move from explicit keyboard bindings (i.e. "document bound") to implicit bindings, based on browser focus. Cf. bpmn-io/diagram-js#662 (comment) how that works (implicit keyboard focus) in the playground.

Generally I 100% support keyboard navigation. The core at least should invite both clickclick and power users.

[pinussilvestrus]

Let's move this one to backlog until we decide to act upon 👍 /cc @christian-konrad

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Niklas Kiefer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}