Conversation
charmander reviewed Jan 9, 2020
Co-Authored-By: Charmander <~@charmander.me>
Owner Author
| Thanks for the reviews my friend! ❤️ Hope your new years was bright and all yer fingers stayed in 1 piece! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #2058 and #2051...I delayed releasing this until I could type again after 🔪 my finger on new years eve 🎆 😢 . I noticed when typing up the changelog that I unintentionally entirely removed the ability to control the pg-query-stream's highWaterMark through the "proper" node readablestream config value so I added that back in with tests.
Now that I can (mostly) type okay....let's get this out! Immediately following this release today I'm going to put up a patch to fix a regression mentioned in #2056.