Skip to content

Add SaveOptional() to save predicates if they exist, and add the#386

Merged
barakmich merged 1 commit intocayleygraph:masterfrom
barakmich:optional_path
Mar 23, 2016
Merged

Add SaveOptional() to save predicates if they exist, and add the#386
barakmich merged 1 commit intocayleygraph:masterfrom
barakmich:optional_path

Conversation

@barakmich
Copy link
Member

@barakmich barakmich commented Mar 23, 2016

appropriate test.
@dennwc
Copy link
Member

dennwc commented Mar 23, 2016

Same as #365 :)
@bobbyrullo
Copy link

bobbyrullo commented Mar 23, 2016

LGTM, except for that test not passing,and that I am not super familiar with this codebase yet.
@barakmich
Copy link
Member Author

barakmich commented Mar 23, 2016

The test isn't passing because something is up on tip.

This is the same as #365. So I'm going to merge #365, and change this to incorporate the additional test.
@bobbyrullo
Copy link

bobbyrullo commented Mar 23, 2016

👍
@bobbyrullo
Copy link

bobbyrullo commented Mar 23, 2016

and thanks!
@barakmich barakmich merged commit 15ab599 into cayleygraph:master Mar 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@barakmich @dennwc @bobbyrullo